docs: Added adr template and protojson adr #1214

darrelmiller · 2025-11-20T23:19:34Z

Added ADR that captures decision to use ProtoJSON as the normative reference for JSON serialization

gemini-code-assist · 2025-11-20T23:20:43Z

Summary of Changes

Hello @darrelmiller, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an ADR template and a specific ADR (ADR-001) that documents the decision to use ProtoJSON for JSON serialization in the A2A specification. This aims to standardize JSON serialization and improve interoperability, but it also acknowledges potential breaking changes and migration efforts for existing implementations.

Highlights

ADR Template: Adds a template for Architecture Decision Records (ADRs) to standardize the decision-making process.
ProtoJSON ADR: Introduces ADR-001, which captures the decision to use ProtoJSON as the normative reference for JSON serialization within the A2A specification.
Breaking Changes: Highlights potential breaking changes due to the adoption of ProtoJSON, specifically regarding enum casing (SCREAMING_SNAKE_CASE) and the loss of roundtrip capability for unknown values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces an Architecture Decision Record (ADR) for using ProtoJSON as the standard for JSON serialization, along with a template for future ADRs. The changes are well-structured and clearly articulate the decision-making process. My feedback includes a few minor corrections for typos and grammar in the ADR, and a suggestion to improve consistency between the new ADR and the template.

adrs/adr-001-protojson-serialization.md

adrs/adr-template.md

…rotoJSON serialization

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

darrelmiller · 2025-11-25T17:54:44Z

/vote

git-vote · 2025-11-25T17:54:47Z

Vote created

@darrelmiller has called for a vote on Added adr template and protojson adr (#1214).

The members of the following teams have binding votes:

Team
@a2aproject/a2a-tsc

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor	Against	Abstain
👍	👎	👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 7days. It will pass if at least 51% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

git-vote · 2025-11-26T17:57:56Z

Vote status

So far 37.50% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
3	0	0	5

Binding votes (3)

User	Vote	Timestamp
ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00
@lerhaupt	Pending
@geneknit	Pending
@hughesthe1st	Pending
@000-000-000-000-000	Pending
@SivaNSAP	Pending

git-vote · 2025-11-27T17:59:29Z

Vote status

So far 37.50% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
3	0	0	5

Binding votes (3)

User	Vote	Timestamp
ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00
@lerhaupt	Pending
@geneknit	Pending
@hughesthe1st	Pending
@000-000-000-000-000	Pending
@SivaNSAP	Pending

git-vote · 2025-11-28T18:27:57Z

Vote status

So far 37.50% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
3	0	0	5

Binding votes (3)

User	Vote	Timestamp
ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00
@lerhaupt	Pending
@geneknit	Pending
@hughesthe1st	Pending
@000-000-000-000-000	Pending
@SivaNSAP	Pending

git-vote · 2025-11-29T18:29:29Z

Vote status

So far 37.50% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
3	0	0	5

Binding votes (3)

User	Vote	Timestamp
ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00
@lerhaupt	Pending
@geneknit	Pending
@hughesthe1st	Pending
@000-000-000-000-000	Pending
@SivaNSAP	Pending

git-vote · 2025-11-30T18:57:57Z

Vote status

So far 37.50% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
3	0	0	5

Binding votes (3)

User	Vote	Timestamp
ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00
@lerhaupt	Pending
@geneknit	Pending
@hughesthe1st	Pending
@000-000-000-000-000	Pending
@SivaNSAP	Pending

git-vote · 2025-12-01T18:59:30Z

Vote status

So far 37.50% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
3	0	0	5

Binding votes (3)

User	Vote	Timestamp
ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00
@lerhaupt	Pending
@geneknit	Pending
@hughesthe1st	Pending
@000-000-000-000-000	Pending
@SivaNSAP	Pending

git-vote · 2025-12-02T17:55:00Z

Vote closed

The vote did not pass.

50.00% of the users with binding vote were in favor and 0.00% were against (passing threshold: 51%).

Summary

In favor	Against	Abstain	Not voted
4	0	0	4

Binding votes (4)

User	Vote	Timestamp
@000-000-000-000-000	In favor	2025-12-02 0:36:28.0 +00:00:00
@ToddSegal	In favor	2025-11-25 17:57:04.0 +00:00:00
@darrelmiller	In favor	2025-11-26 12:27:04.0 +00:00:00
@muscariello	In favor	2025-11-26 16:56:57.0 +00:00:00

amye · 2025-12-02T19:24:11Z

This vote actually passed, editing labels to be clear.

adrs/adr-001-protojson-serialization.md

…ing check

Added adr template and protojson adr

bb8a41e

darrelmiller requested a review from a team as a code owner November 20, 2025 23:19

gemini-code-assist bot reviewed Nov 20, 2025

View reviewed changes

adrs/adr-001-protojson-serialization.md Outdated Show resolved Hide resolved

adrs/adr-001-protojson-serialization.md Outdated Show resolved Hide resolved

adrs/adr-template.md Outdated Show resolved Hide resolved

darrelmiller and others added 3 commits November 20, 2025 18:23

docs: Update ADR-001 to include additional considerations regarding P…

689c9c7

…rotoJSON serialization

Update adrs/adr-001-protojson-serialization.md

7fd9cd7

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update adrs/adr-template.md

9668054

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

darrelmiller mentioned this pull request Nov 21, 2025

[Bug]: Update specification to take dependency on ProtoJSON specification for JSON serialization #1217

Open

1 task

darrelmiller and others added 2 commits November 21, 2025 12:24

Update adrs/adr-001-protojson-serialization.md

6ace34a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Added some more consequences

84dac80

git-vote bot added gitvote gitvote/open labels Nov 25, 2025

amye added the TSC Review To be reviewed by the Technical Steering Committee label Nov 26, 2025

github-project-automation bot added this to TSC Review Nov 26, 2025

github-project-automation bot moved this to Backlog in TSC Review Nov 26, 2025

amye moved this from Backlog to In Voting in TSC Review Nov 26, 2025

darrelmiller added 2 commits November 30, 2025 12:05

Merge branch 'main' into adr-protojson

c9c4acf

Fixed markdown linting errors

f235b95

git-vote bot added gitvote/closed gitvote/failed and removed gitvote/open labels Dec 2, 2025

amye added gitvote/passed and removed gitvote/failed labels Dec 2, 2025

muscariello and others added 3 commits December 11, 2025 10:40

Merge branch 'main' into adr-protojson

914fd9b

Merge branch 'main' into adr-protojson

f4ab242

Merge branch 'main' into adr-protojson

9e250e5

ishymko reviewed Jan 7, 2026

View reviewed changes

adrs/adr-001-protojson-serialization.md Show resolved Hide resolved

ishymko mentioned this pull request Jan 7, 2026

HTTP+JSON payload shape mismatches proto‑JSON (ADK/Agent Engine 400s) a2aproject/a2a-js#291

Closed

1 task

fix(spelling): Add 'adr', 'adrs', and 'ADR' to allowed terms in spell…

e0e376b

…ing check

darrelmiller changed the title ~~Added adr template and protojson adr~~ docs: Added adr template and protojson adr Jan 12, 2026

darrelmiller and others added 4 commits January 12, 2026 11:34

resorted allow.txt

477a092

fix(spelling): Add 'protojson' to allowed terms in spelling check

1fc1a7e

Merge branch 'main' into adr-protojson

829ab16

Merge branch 'main' into adr-protojson

d8c1fb7

darrelmiller merged commit e6c5699 into main Jan 14, 2026
11 of 12 checks passed

darrelmiller deleted the adr-protojson branch January 14, 2026 03:16

github-project-automation bot moved this from In Voting to Done in TSC Review Jan 14, 2026

docs: Added adr template and protojson adr #1214

docs: Added adr template and protojson adr #1214

Uh oh!

Conversation

darrelmiller commented Nov 20, 2025

Uh oh!

gemini-code-assist bot commented Nov 20, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

darrelmiller commented Nov 25, 2025

Uh oh!

git-vote bot commented Nov 25, 2025

Vote created

How to vote

Uh oh!

git-vote bot commented Nov 26, 2025

Vote status

Summary

Binding votes (3)

Uh oh!

git-vote bot commented Nov 27, 2025

Vote status

Summary

Binding votes (3)

Uh oh!

git-vote bot commented Nov 28, 2025

Vote status

Summary

Binding votes (3)

Uh oh!

git-vote bot commented Nov 29, 2025

Vote status

Summary

Binding votes (3)

Uh oh!

git-vote bot commented Nov 30, 2025

Vote status

Summary

Binding votes (3)

Uh oh!

git-vote bot commented Dec 1, 2025

Vote status

Summary

Binding votes (3)

Uh oh!

git-vote bot commented Dec 2, 2025

Vote closed

Summary

Binding votes (4)

Uh oh!

amye commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants